hunyadi-dev commented on a change in pull request #835:
URL: https://github.com/apache/nifi-minifi-cpp/pull/835#discussion_r452128161
##########
File path: extensions/http-curl/tests/HTTPIntegrationBase.h
##########
@@ -135,6 +135,9 @@ class VerifyC2Describe : public VerifyC2Base {
}
void runAssertions() override {
+ // This class is never used for running assertions, but we are forced to
wait for DescribeManifestHandler to verifyJsonHasAgentManifest
+ // if we were to log something on finished verification, we could poll on
finding it
+ std::this_thread::sleep_for(std::chrono::milliseconds(wait_time_));
Review comment:
I do not want to bring it back. The model this test follows is a bad
one, using a testharness not to actually run tests but just to set up a
`FlowController` and block until other assertions happen. A good refactor would
be to rewrite the logic used here, but that would have been too big of a change
for this PR. This comment is a good indicator of what is actually going on
(`runAssertions` only waits for assertions to be run).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
