turcsanyip commented on a change in pull request #4370:
URL: https://github.com/apache/nifi/pull/4370#discussion_r451834785
##########
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/FileInfo.java
##########
@@ -217,6 +217,20 @@ public Builder group(String group) {
}
}
+ public static String permissionToString(int fileModeOctal) {
+ if(fileModeOctal > 0777 || fileModeOctal < 00) {
+ throw new RuntimeException("Invalid permission numerals");
+ }
+ char[] PERM = "xwrxwrxwr".toCharArray();
Review comment:
I meant it to be a constant, that's why the uppercase.
##########
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/UnpackContent.java
##########
@@ -110,6 +118,14 @@
public static final String OCTET_STREAM = "application/octet-stream";
+ public static final String FILE_LAST_MODIFIED_TIME_ATTRIBUTE =
"file.lastModifiedTime";
+ public static final String FILE_OWNER_ATTRIBUTE = "file.owner";
+ public static final String FILE_GROUP_ATTRIBUTE = "file.group";
+ public static final String FILE_PERMISSIONS_ATTRIBUTE = "file.permissions";
+
+ public static final String FILE_MODIFIED_DATE_ATTR_FORMAT =
"yyyy-MM-dd'T'HH:mm:ssZ";
+ public static final DateTimeFormatter dateTimeFormatter =
DateTimeFormatter.ofPattern(FILE_MODIFIED_DATE_ATTR_FORMAT).withZone(ZoneId.systemDefault());
Review comment:
Please use uppercase for constant names.
##########
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/FileInfo.java
##########
@@ -217,6 +217,20 @@ public Builder group(String group) {
}
}
+ public static String permissionToString(int fileModeOctal) {
+ if(fileModeOctal > 0777 || fileModeOctal < 00) {
Review comment:
Formatting: `if (`
##########
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/FileInfo.java
##########
@@ -217,6 +217,20 @@ public Builder group(String group) {
}
}
+ public static String permissionToString(int fileModeOctal) {
Review comment:
As it is a pure function without side effects, some unit tests could be
added easily.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
