[ 
https://issues.apache.org/jira/browse/OPENNLP-544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489230#comment-13489230
 ] 

Chris Fournier commented on OPENNLP-544:
----------------------------------------

I think that you are correct on all three points. Thanks! To that end, I've 
added a new patch that now:

1) Removes dependencies in types/signatures to the implementation;
2) Moves many comments to the interface and leaves Javadoc references to the 
interface in the implementation;
3) Removes compareTo from the interface definition, and instead has the 
interface extend Comparable;
4) Adds the ASF 2.0 license to the header.

Any further improvements?

                
> Added an interface for opennlp.tools.util.Span
> ----------------------------------------------
>
>                 Key: OPENNLP-544
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-544
>             Project: OpenNLP
>          Issue Type: Improvement
>          Components: Tokenizer
>    Affects Versions: tools-1.5.3
>            Reporter: Chris Fournier
>            Priority: Trivial
>              Labels: newbie, patch
>             Fix For: tools-1.5.3
>
>         Attachments: Spannable_OPENNLP-544-1.5.3.patch, 
> Spannable_OPENNLP-544-1.5.3.patch
>
>
> Added an interface, opennlp.tools.util.Spannable, to allow for the creation 
> of objects that can span text and fulfill the same functionality as Span 
> without necessarily needing to extend it (currently implemented only by 
> opennlp.tools.util.Span).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to