[
https://issues.apache.org/jira/browse/OPENNLP-544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13493464#comment-13493464
]
Joern Kottmann commented on OPENNLP-544:
----------------------------------------
In the 1.5.x series of releases we cannot break backward compatibility. All
existing user code which works with 1.5.0 must also work with 1.5.2 or 1.5.3.
This patch is breaking backward compatibility in some places.
I personally do not see the advantage in the current code to have these other
objects implementing the Spannable interface, it gives the user the illusion
that it might be ok to pass in an array of Parse token objects and the text to
a TokenNameFinder, but it is not because the offsets in the Parse object have a
different semantics as they are used in the TokenNameFidner (char offsets vs.
token offsets).
Anyway, having a Spannable without further refactoring in the OpenNLP code base
does not make much sense to me. I suggest that we do this later e.g. for 1.6
when we have some freedom to change our API as well and be able to fix things
like the Parse object.
What do you think?
> Added an interface for opennlp.tools.util.Span
> ----------------------------------------------
>
> Key: OPENNLP-544
> URL: https://issues.apache.org/jira/browse/OPENNLP-544
> Project: OpenNLP
> Issue Type: Improvement
> Components: Tokenizer
> Affects Versions: tools-1.5.3
> Reporter: Chris Fournier
> Priority: Trivial
> Labels: newbie, patch
> Fix For: tools-1.5.3
>
> Attachments: SpannableApplied_OPENNLP-544-1.5.3.patch,
> Spannable_OPENNLP-544-1.5.3.patch
>
>
> Added an interface, opennlp.tools.util.Spannable, to allow for the creation
> of objects that can span text and fulfill the same functionality as Span
> without necessarily needing to extend it (currently implemented only by
> opennlp.tools.util.Span).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
