[
https://issues.apache.org/jira/browse/OPENNLP-1160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16318521#comment-16318521
]
ASF GitHub Bot commented on OPENNLP-1160:
-----------------------------------------
kottmann commented on issue #305: OPENNLP-1160: avoid letting users specify
CachedFeatureGeneratorFacto…
URL: https://github.com/apache/opennlp/pull/305#issuecomment-356303272
Eventually it would be nice to use the new feature generator format also for
other components. The cache is only suitable as it is today for sequence
generators (where the feature doesn't change based on the previous outcomes).
How would deal with this e.g. for langdetect? Disable it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> avoid letting users specify CachedFeatureGeneratorFactory in XML config
> -----------------------------------------------------------------------
>
> Key: OPENNLP-1160
> URL: https://issues.apache.org/jira/browse/OPENNLP-1160
> Project: OpenNLP
> Issue Type: Improvement
> Components: Formats, Name Finder
> Affects Versions: 1.8.3
> Reporter: Koji Sekiguchi
> Assignee: Koji Sekiguchi
> Priority: Minor
>
> This is similar to OPENNLP-1159. When I'm working on OPENNLP-1154, I think we
> should do it for better use.
> I'd like to implement this as an independent ticket from OPENNLP-1154 and
> OPENNLP-1159 to make patch easy to read.
> And this ticket is somewhat different from OPENNLP-1159 as users must be able
> to control the framework uses CachedFeatureGeneratorFactory or not.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
