[ 
https://issues.apache.org/jira/browse/OPENNLP-1160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16269980#comment-16269980
 ] 

Koji Sekiguchi commented on OPENNLP-1160:
-----------------------------------------

After committing all of OPENNLP-1154, OPENNLP-1159 and OPENNLP-1160, the XML 
config looks like:

{code:xml}
<featureGenerators name="nameFinder">
        <generator 
class="opennlp.tools.util.featuregen.WindowFeatureGeneratorFactory">
          <int name="prevLength">2</int>
          <int name="nextLength">2</int>
          <generator 
class="opennlp.tools.util.featuregen.TokenClassFeatureGeneratorFactory"/>
        </generator>
        <generator 
class="opennlp.tools.util.featuregen.WindowFeatureGeneratorFactory">
          <int name="prevLength">2</int>
          <int name="nextLength">2</int>
          <generator 
class="opennlp.tools.util.featuregen.TokenFeatureGeneratorFactory"/>
        </generator>
        <generator 
class="opennlp.tools.util.featuregen.DefinitionFeatureGeneratorFactory"/>
        <generator 
class="opennlp.tools.util.featuregen.PreviousMapFeatureGeneratorFactory"/>
        <generator 
class="opennlp.tools.util.featuregen.BigramNameFeatureGeneratorFactory"/>
        <generator 
class="opennlp.tools.util.featuregen.SentenceFeatureGeneratorFactory">
          <bool name="begin">true</bool>
          <bool name="end">false</bool>
        </generator>
</featureGenerators>
{code}


> avoid letting users specify CachedFeatureGeneratorFactory in XML config
> -----------------------------------------------------------------------
>
>                 Key: OPENNLP-1160
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-1160
>             Project: OpenNLP
>          Issue Type: Improvement
>          Components: Formats, Name Finder
>    Affects Versions: 1.8.3
>            Reporter: Koji Sekiguchi
>            Assignee: Koji Sekiguchi
>            Priority: Minor
>
> This is similar to OPENNLP-1159. When I'm working on OPENNLP-1154, I think we 
> should do it for better use.
> I'd like to implement this as an independent ticket from OPENNLP-1154 and 
> OPENNLP-1159 to make patch easy to read.
> And this ticket is somewhat different from OPENNLP-1159 as users must be able 
> to control the framework uses CachedFeatureGeneratorFactory or not.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to