[ 
https://issues.apache.org/jira/browse/OPENNLP-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17520257#comment-17520257
 ] 

ASF GitHub Bot commented on OPENNLP-1351:
-----------------------------------------

jzonthemtn opened a new pull request, #410:
URL: https://github.com/apache/opennlp/pull/410

   This PR fixes the location of the ONNX models for the eval tests and fixes 
an expected value.
   
   
   ---
   Thank you for contributing to Apache OpenNLP.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [X] Is there a JIRA ticket associated with this PR? Is it referenced 
        in the commit message?
   
   - [X] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
   
   - [X] Has your PR been rebased against the latest commit within the target 
branch (typically master)?
   
   - [X] Is your initial contribution a single, squashed commit?
   
   ### For code changes:
   - [X] Have you ensured that the full suite of tests is executed via mvn 
clean install at the root opennlp folder?
   - [ ] Have you written or updated unit tests to verify your changes?
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
   - [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file in opennlp folder?
   - [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found in opennlp folder?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which 
it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check GitHub Actions for 
build issues and submit an update to your PR as soon as possible.
   




> Support ONNX models
> -------------------
>
>                 Key: OPENNLP-1351
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-1351
>             Project: OpenNLP
>          Issue Type: Task
>            Reporter: Jeff Zemerick
>            Assignee: Jeff Zemerick
>            Priority: Major
>             Fix For: 1.9.5
>
>
> With support for ONNX models, OpenNLP can utilize the newer transformer 
> architecture models. Models can be trained in PyTorch or Tensorflow and 
> converted to ONNX and used from OpenNLP.
> This task is to provide OpenNLP interface implementations using ONNX models.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to