[
https://issues.apache.org/jira/browse/OPENNLP-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17520514#comment-17520514
]
ASF GitHub Bot commented on OPENNLP-1351:
-----------------------------------------
jzonthemtn commented on code in PR #410:
URL: https://github.com/apache/opennlp/pull/410#discussion_r847234944
##########
opennlp-dl/src/test/java/opennlp/dl/namefinder/NameFinderDLEval.java:
##########
@@ -54,7 +54,7 @@ public void tokenNameFinder1Test() throws Exception {
Assert.assertEquals(1, spans.length);
Assert.assertEquals(0, spans[0].getStart());
Assert.assertEquals(2, spans[0].getEnd());
- Assert.assertEquals(0.8251646041870118, spans[0].getProb(), 0.0);
+ Assert.assertEquals(8.251646041870117, spans[0].getProb(), 0.0);
Review Comment:
I think this value is from when I was experimenting with getting it to be a
value between 0 and 1 like the other probability values and decided to leave
that for later. When I reverted it I didn't also change the value here.
> Support ONNX models
> -------------------
>
> Key: OPENNLP-1351
> URL: https://issues.apache.org/jira/browse/OPENNLP-1351
> Project: OpenNLP
> Issue Type: Task
> Reporter: Jeff Zemerick
> Assignee: Jeff Zemerick
> Priority: Major
> Fix For: 1.9.5
>
>
> With support for ONNX models, OpenNLP can utilize the newer transformer
> architecture models. Models can be trained in PyTorch or Tensorflow and
> converted to ONNX and used from OpenNLP.
> This task is to provide OpenNLP interface implementations using ONNX models.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
