[
https://issues.apache.org/jira/browse/OPENNLP-1448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17679080#comment-17679080
]
ASF GitHub Bot commented on OPENNLP-1448:
-----------------------------------------
rzo1 opened a new pull request, #492:
URL: https://github.com/apache/opennlp/pull/492
Thank you for contributing to Apache OpenNLP.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically main)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
clean install at the root opennlp folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [x] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] If applicable, have you updated the LICENSE file, including the main
LICENSE file in opennlp folder?
- [x] If applicable, have you updated the NOTICE file, including the main
NOTICE file found in opennlp folder?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
This PR is the first sub-task of
[OPENNLP-1447](https://issues.apache.org/jira/browse/OPENNLP-1447).
- It introduces `slf4j-api` in OpenNLP and replaces calls to `System.err` or
`System.out` by related logger calls.
- It adds `log4j2` as `runtime` dependency to the OpenNLP distribution +
related configuration and adjusts the scripts accordingly
#### Notes for reviewers:
- Revision of log levels is tracked with
[OPENNLP-1449](https://issues.apache.org/jira/browse/OPENNLP-1449) and is not
scope of the given PR. However, comments on specific log levels are highly
welcome, so they can be tracked and incorporated in OPENNLP-1449.
- Fully use of formatting using the possibilities of SLF4J
eg.`{}`-replacement is tracked with
[OPENNLP-1450](https://issues.apache.org/jira/browse/OPENNLP-1450) and is not
scope of the given PR.
- Log output reduction during the build is currently tracked with
[OPENNLP-1451](https://issues.apache.org/jira/browse/OPENNLP-1451). At the
moment, I introduced `slf4j-simple` as a `test` dependency and disabled log
output. We can discuss how we want to deal with it within OPENNLP-1451.
- If some removed `System.out / System.err` statements (in the tests) are
really needed, please leave a comment. We can easily move them to log statements
#### TODOs for reviewers:
- It would be great, if our heavy CLI users like @atarora can provide
valuable feedback. Due to the absence of a Windows machine, I cannot test the
`.bat` changes - maybe some Windows user can have a look here.
- It would be great, if someone with the `eval` datasets available on
his/her machine can run the `eval` tests and provide feedback, if needed.
- I disabled a few tests, which relied on overriding `System.out` and
gathering the output. Happy to receive ideas on how we can re-write them to
work with `slf4j-simple` in the test context
> Introduce SLF4J in OpenNLP
> --------------------------
>
> Key: OPENNLP-1448
> URL: https://issues.apache.org/jira/browse/OPENNLP-1448
> Project: OpenNLP
> Issue Type: Sub-task
> Reporter: Richard Zowalla
> Assignee: Richard Zowalla
> Priority: Major
>
> This will be the first step regarding OPENNLP-1447.
> Goal is to replace System.err / System.out calls with logger output, which is
> configurable.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
