[
https://issues.apache.org/jira/browse/OPENNLP-1448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17692783#comment-17692783
]
ASF GitHub Bot commented on OPENNLP-1448:
-----------------------------------------
jzonthemtn commented on code in PR #492:
URL: https://github.com/apache/opennlp/pull/492#discussion_r1115982530
##########
opennlp-brat-annotator/src/main/java/opennlp/bratann/NameFinderAnnService.java:
##########
@@ -41,15 +43,16 @@
public class NameFinderAnnService {
+ private static Logger logger =
LoggerFactory.getLogger(NameFinderAnnService.class);
public static SentenceDetector sentenceDetector = new
NewlineSentenceDetector();
public static Tokenizer tokenizer = WhitespaceTokenizer.INSTANCE;
public static TokenNameFinder[] nameFinders;
public static void main(String[] args) throws Exception {
if (args.length == 0) {
- System.out.println("Usage:");
- System.out.println("[NameFinderAnnService -serverPort port]
[-tokenizerModel file] "
+ logger.info("Usage:");
Review Comment:
Do we have any feelings about how messages in a CLI tool should be
displayed? Does changing these to `logger` from `System.out` have any impact?
Is there any chance the message would be missed or somewhere other than
standard out?
> Introduce SLF4J in OpenNLP
> --------------------------
>
> Key: OPENNLP-1448
> URL: https://issues.apache.org/jira/browse/OPENNLP-1448
> Project: OpenNLP
> Issue Type: Sub-task
> Reporter: Richard Zowalla
> Assignee: Richard Zowalla
> Priority: Major
>
> This will be the first step regarding OPENNLP-1447.
> Goal is to replace System.err / System.out calls with logger output, which is
> configurable.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
