[ 
https://issues.apache.org/jira/browse/OPENNLP-1538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803751#comment-17803751
 ] 

ASF GitHub Bot commented on OPENNLP-1538:
-----------------------------------------

l-ma opened a new pull request, #584:
URL: https://github.com/apache/opennlp/pull/584

   This change allows running integration tests locally. Let me know if this is 
on the right track for Jenkins.
   
   Thank you for contributing to Apache OpenNLP.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [X] Is there a JIRA ticket associated with this PR? Is it referenced 
        in the commit message?
   
   - [X] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
   
   - [X] Has your PR been rebased against the latest commit within the target 
branch (typically main)?
   
   - [X] Is your initial contribution a single, squashed commit?
   
   ### For code changes:
   - [ ] Have you ensured that the full suite of tests is executed via mvn 
clean install at the root opennlp folder? One test fails with 
`SSLHandshakeException` from https://opennlp.sourceforge.net/
   - [ ] Have you written or updated unit tests to verify your changes? NOT 
APPLICABLE
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? NOT APPLICABLE
   - [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file in opennlp folder? NOT APPLICABLE
   - [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found in opennlp folder? NOT APPLICABLE
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which 
it is rendered? NOT APPLICABLE
   
   ### Note:
   Please ensure that once the PR is submitted, you check GitHub Actions for 
build issues and submit an update to your PR as soon as possible.




> Ensure all integration tests are run during Eval build
> ------------------------------------------------------
>
>                 Key: OPENNLP-1538
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-1538
>             Project: OpenNLP
>          Issue Type: Task
>          Components: Build, Packaging and Test
>            Reporter: Martin Wiesner
>            Priority: Major
>
> POSTaggerMEIT in the [Jenkins log 
> |https://ci-builds.apache.org/blue/rest/organizations/jenkins/pipelines/OpenNLP/pipelines/eval-tests/runs/312/log/?start=0&download=true],
>  so in consequence a 
> {{cat log.txt | grep POSTaggerMEIT}}
> gives an empty result. 
> Moreover, any test that ends with *IT.java do not show up in the Jenkins log.
> Aims:
> - Make sure, the ITs are run during (eval) builds
> - Introduce and / or check for an appropriate Maven profile that executes ITs 
> in a separate phase, eg. via maven-failsafe-plugin



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to