[ 
https://issues.apache.org/jira/browse/OPENNLP-1538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17804991#comment-17804991
 ] 

ASF GitHub Bot commented on OPENNLP-1538:
-----------------------------------------

rzo1 commented on PR #584:
URL: https://github.com/apache/opennlp/pull/584#issuecomment-1884320885

   > I addressed the `POSTaggerMEIT.testPOSTagger` test but used 
`Assertions.assertArrayEquals` like in `ChunkerMEIT`.
   > 
   > `ChunkerMEIT` fails because 
https://dlcdn.apache.org/opennlp/models/ud-models-1.0/ does not have any 
Chunker file. I didn't find any Chunker anywhere under 
https://dlcdn.apache.org/opennlp/, but I did find a Chunker here: 
https://opennlp.sourceforge.net/models-1.5/
   
   Nice finding. 
[DownloadUtil](https://github.com/apache/opennlp/blob/main/opennlp-tools/src/main/java/opennlp/tools/util/DownloadUtil.java)
 only supports downloads for "ud-models". Looks like we missed a chunker model 
in 
[OPENNLP-1318](https://github.com/apache/opennlp/commit/70b614773d1a74aecadd7794abfdbf45b36676b7).
 We would either need to train a related EN chunker model and add it to the ud 
models (guess, we should provide one) or switch the test to use an existing 
model. Thoughts, @mawiesne @jzonthemtn @kinow ?




> Ensure all integration tests are run during Eval build
> ------------------------------------------------------
>
>                 Key: OPENNLP-1538
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-1538
>             Project: OpenNLP
>          Issue Type: Task
>          Components: Build, Packaging and Test
>            Reporter: Martin Wiesner
>            Priority: Major
>
> POSTaggerMEIT in the [Jenkins log 
> |https://ci-builds.apache.org/blue/rest/organizations/jenkins/pipelines/OpenNLP/pipelines/eval-tests/runs/312/log/?start=0&download=true],
>  so in consequence a 
> {{cat log.txt | grep POSTaggerMEIT}}
> gives an empty result. 
> Moreover, any test that ends with *IT.java do not show up in the Jenkins log.
> Aims:
> - Make sure, the ITs are run during (eval) builds
> - Introduce and / or check for an appropriate Maven profile that executes ITs 
> in a separate phase, eg. via maven-failsafe-plugin



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to