https://issues.apache.org/ooo/show_bug.cgi?id=121421
--- Comment #15 from Pedro Giffuni <[email protected]> --- (In reply to comment #13) > (In reply to comment #12) > > > Ignoring MAX_RAND is a very bad idea. > That would only be the case if the % failed in the initialization. > The seed will be biased toward lower values. It's not a serious issue but it doesn't buy us anything either. > > I also found my implementation is incomplete: to avoid precision issues the > > complete implementation does some adjustments that involve substracting. > > That may be cause for microsoft's bug. > This is apparently not a problem on systems where sizeof(int) > 3. If it > were, we could see negative IX,IY,IZ values at some point. It might be > safer to declare those as longs, though. It will be interesting to see if > that changes anything. For the 2006 implementation you do need to do the adjustment to avoid 64 bit integer math. > > > > The algorithm is rather old and thought for 16 bit architectures. There has > > been a revision in 2007 (which obviously didn't make it into Office 2003). I > > will update this soon. > I noticed that too. The maximum periods of the individual IX, IY, and IZ > series are terribly small. Do you have a reference on any analysis of the > 2007 version and the rationale for the choice of its parameters? (In this > case, watching out for multiplication range errors and %-buts will also be > more important.) I found this on the net: http://www.eurometros.org/file_download.php?file_key=247 However I am having two problems: 1) seeding 2) It's not working (?). -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.
