https://bz.apache.org/ooo/show_bug.cgi?id=127639
Andrea Pescetti <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|CONFIRMED |ACCEPTED --- Comment #11 from Andrea Pescetti <[email protected]> --- Thanks for your contribution! I played with it and it looks very nice. I like the updateVersion.config file approach. Nice and compact. Having it as a YAML file (or INI file) would look more modern, but honestly the current approach works without any external libraries or prerequisites and I must admit it's in line with the approach of other OpenOffice scripting - we rarely use modern features. So I don't see this as an issue. - Line 6: typo in script name (trivial) - line 17: since the scripts supports being run as an external tool, it would make sense to have it look for a default config in its own dir, using $0 appropriately. I mean, if the local one (from $PWD) is unset then try the external one (from the $0 container) before dying. - same code: we should probably die if $configfile is not readable - If we are going to normally run it outside main/, it is fine. Usually tools assume that they are run within main/, but so long as a check is added to ensure that the supplied dir (or, missing that, the current dir) contains a 'main/' subdirectory it will work. - We should also check that a version is actually supplied For the rest, executing a test with 4.1.6 everything looks fine, except this: --- solenv/inc/minor.mk (revision 1824713) +++ solenv/inc/minor.mk (local copy) @@ -18,8 +18,8 @@ # under the License. # # ************************************************************* -RSCVERSION=415 -RSCREVISION=415m1(Build:9789) +RSCVERSION=416 +RSCREVISION=415m10(Build:9789) BUILD=9789 -LAST_MINOR=m1 +LAST_MINOR=m10 SOURCEVERSION=AOO415 This is not OK since internally this means (piece-wise): RSCREVISION=415m10(Build:9789) 415 = "This is based on 415" - so it should be 416 m = Fixed shorthand for "milestone", stays "m" 10 = "This is milestone number 10" - this is wrong, in your case you will always have 1 here (it's milestone 1 of the new 416 series) (Build:9789) = This can be fixed later and it is obviously linked to the BUILD below, which should be increased but we don't have a logic for that so we can discuss it later So basically the only error is LAST_MINOR that should be reset to m1 (or anyway not increased), and RSCREVISION that is formed from it. -- You are receiving this mail because: You are the assignee for the issue.
