https://bz.apache.org/ooo/show_bug.cgi?id=127639

--- Comment #13 from Ash <[email protected]> ---
Created attachment 86355
  --> https://bz.apache.org/ooo/attachment.cgi?id=86355&action=edit
add corrections for initial comments

All of the below are fixed by this version:

- Line 6: typo in script name
- line 17: since the scripts supports being run as an external tool, it would
make sense to have it look for a default config in its own dir, using $0
appropriately. I mean, if the local one (from $PWD) is unset then try the
external one (from the $0 container) before dying.
- same code: we should probably die if $configfile is not readable 
- If we are going to normally run it outside main/, it is fine. Usually tools
assume that they are run within main/, but so long as a check is added to
ensure that the supplied dir (or, missing that, the current dir) contains a
'main/' subdirectory it will work.
- We should also check that a version is actually supplied

-- 
You are receiving this mail because:
You are the assignee for the issue.

Reply via email to