sciabarracom commented on a change in pull request #119: Ack and versioning
[work in progress]
URL:
https://github.com/apache/openwhisk-runtime-go/pull/119#discussion_r370158860
##########
File path: openwhisk/actionProxy.go
##########
@@ -72,6 +72,18 @@ func NewActionProxy(baseDir string, compiler string,
outFile *os.File, errFile *
//SetEnv sets the environment
func (ap *ActionProxy) SetEnv(env map[string]interface{}) {
+ // Propagate proxy version
+ ap.env["__OW_PROXY_VERSION"] = Version
+ // propagate OW_EXECUTION_ENV as __OW_EXECUTION_ENV
+ ee := os.Getenv("OW_EXECUTION_ENV")
+ if ee != "" {
+ ap.env["__OW_EXECUTION_ENV"] = ee
+ }
+ // require an ack
+ wa := os.Getenv("OW_WAIT_FOR_ACK")
+ if wa != "" {
+ ap.env["__OW_WAIT_FOR_ACK"] = wa
Review comment:
yes ... I mark I want to wait_for_ack in the Dockerfile, but I pass the
information to the action with an environment variable with a different name
(adding the __)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
