sciabarracom commented on a change in pull request #119: Ack and versioning
[work in progress]
URL:
https://github.com/apache/openwhisk-runtime-go/pull/119#discussion_r370159766
##########
File path: openwhisk/actionProxy.go
##########
@@ -72,6 +72,18 @@ func NewActionProxy(baseDir string, compiler string,
outFile *os.File, errFile *
//SetEnv sets the environment
func (ap *ActionProxy) SetEnv(env map[string]interface{}) {
+ // Propagate proxy version
+ ap.env["__OW_PROXY_VERSION"] = Version
+ // propagate OW_EXECUTION_ENV as __OW_EXECUTION_ENV
+ ee := os.Getenv("OW_EXECUTION_ENV")
Review comment:
because the actions always uses the __OW variables while the proxy uses the
OW variables. In short OW_VARIABLES are parameters for the proxy while the __OW
are parameters for the action. It is all documented in the ENVVARS document I
added
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
