rabbah commented on a change in pull request #4790: Config runtime
URL: https://github.com/apache/openwhisk/pull/4790#discussion_r371009654
 
 

 ##########
 File path: tests/src/test/scala/common/WhiskProperties.java
 ##########
 @@ -258,10 +258,40 @@ public static int getControllerBasePort() {
         return 
Integer.parseInt(whiskProperties.getProperty("controller.host.basePort"));
     }
 
+    public static String getControllerProtocol() {
 
 Review comment:
   i dont think any of these changes are necessary if you read configs through 
pureconfig.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to