rabbah commented on a change in pull request #4790: Config runtime URL: https://github.com/apache/openwhisk/pull/4790#discussion_r371009470
########## File path: core/invoker/src/main/scala/org/apache/openwhisk/core/invoker/DefaultInvokerServer.scala ########## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.openwhisk.core.invoker + +import akka.actor.ActorSystem +import akka.http.scaladsl.model.StatusCodes +import akka.http.scaladsl.model.headers.BasicHttpCredentials +import akka.http.scaladsl.server.Route +import org.apache.openwhisk.common.{InvokerCredentials, Logging, TransactionId} +import org.apache.openwhisk.core.ConfigKeys +import org.apache.openwhisk.core.containerpool.PrewarmingConfig +import org.apache.openwhisk.core.entity.{CodeExecAsString, ExecManifest} +import org.apache.openwhisk.http.BasicRasService + +import pureconfig._ +import pureconfig.generic.auto._ + +import scala.concurrent.ExecutionContext + +/** + * Implements web server to handle certain REST API calls. + */ +class DefaultInvokerServer(val invoker: InvokerCore)(implicit val ec: ExecutionContext, + val actorSystem: ActorSystem, + val logger: Logging) + extends BasicRasService { + + private val invokerCredentials = loadConfigOrThrow[InvokerCredentials](ConfigKeys.invokerCredentials) + + override def routes(implicit transid: TransactionId): Route = { Review comment: how will new runtime images get pulled to the invoker nodes? are you assuming they get pulled either via stem-cell "run" or when an action actually runs in the future? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
