rabbah commented on a change in pull request #479: Trigger parameter issue
URL: https://github.com/apache/openwhisk-cli/pull/479#discussion_r371932875
##########
File path: tests/src/test/scala/system/basic/WskCliBasicTests.scala
##########
@@ -451,7 +451,7 @@ class WskCliBasicTests extends TestHelpers with
WskTestHelpers {
getJSONFromResponse(trigger.stdout, true).fields("parameters") shouldBe
JsArray(
JsObject("key" -> JsString("a"), "value" -> JsString("A")))
getJSONFromResponse(trigger.stdout, true).fields("publish") shouldBe
false.toJson
- getJSONFromResponse(trigger.stdout, true).fields("version") shouldBe
"0.0.2".toJson
+ getJSONFromResponse(trigger.stdout, true).fields("version") shouldBe
"0.0.1".toJson
Review comment:
this is semantic changing - it suggests there was a call to trigger update
somewhere before that is no longer occurring.
in fact on line 438 and 439 you see there was a `create` and then an
`update`. So I think this change is not correct and should be reverted.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
