rabbah commented on a change in pull request #479: Trigger parameter issue
URL: https://github.com/apache/openwhisk-cli/pull/479#discussion_r371933869
##########
File path: commands/trigger.go
##########
@@ -594,10 +579,42 @@ func (t *Trigger) Update(Client *whisk.Client, args
[]string) error {
}
}
+ //if there is no feed attached to this trigger
+ if len(fullFeedName) < 1 {
+ //but user indicate feed parameter change, we issue
error message.
+ if len(Flags.trigger.feedParam) > 0 {
+ whisk.Debug(whisk.DbgError, "trigger %+v is
found but it does not contain a feed. \n", trigger)
+ errStr :=
wski18n.T("triggerDoesNotContainFeed", map[string]interface{}{"name":
qualifiedName.GetEntityName()})
Review comment:
Please look at using a constant in
https://github.com/apache/openwhisk-cli/blob/master/commands/messages.go
instead of a string `triggerDoesNotContainFeed` which requires a matching entry
in the localization file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
