markusthoemmes commented on a change in pull request #4834: Replace to[Type]
calls with explicit types.
URL: https://github.com/apache/openwhisk/pull/4834#discussion_r383401282
##########
File path:
common/scala/src/main/scala/org/apache/openwhisk/core/database/cosmosdb/CosmosDBSupport.scala
##########
@@ -93,5 +92,5 @@ private[cosmosdb] trait CosmosDBSupport extends
RxObservableImplicits with Cosmo
protected def querySpec(id: String) =
new SqlQuerySpec("SELECT * FROM root r WHERE r.id=@id", new
SqlParameterCollection(new SqlParameter("@id", id)))
- protected def asSeq[T <: Resource](r: FeedResponse[T]): immutable.Seq[T] =
r.getResults.asScala.to[immutable.Seq]
+ protected def asVector[T <: Resource](r: FeedResponse[T]): Vector[T] =
r.getResults.asScala.toVector
Review comment:
Chose a vector here as it's the goto "default" data-structure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
