markusthoemmes commented on a change in pull request #4834: Replace to[Type]
calls with explicit types.
URL: https://github.com/apache/openwhisk/pull/4834#discussion_r383401487
##########
File path:
tests/src/test/scala/org/apache/openwhisk/core/containerpool/kubernetes/test/KubernetesContainerTests.scala
##########
@@ -489,15 +490,15 @@ class KubernetesContainerTests
object KubernetesContainerTests {
def logSource(logLine: TypedLogLine, appendSentinel: Boolean):
Source[TypedLogLine, Any] =
- logSource(Seq(logLine), appendSentinel)
+ logSource(Queue(logLine), appendSentinel)
- def logSource(logs: Seq[TypedLogLine], appendSentinel: Boolean):
Source[TypedLogLine, Any] =
- Source(toLogs(logs, appendSentinel).to[immutable.Seq])
+ def logSource(logs: Queue[TypedLogLine], appendSentinel: Boolean):
Source[TypedLogLine, Any] =
+ Source(toLogs(logs, appendSentinel))
- def toLogs(logLine: TypedLogLine, appendSentinel: Boolean):
Seq[TypedLogLine] =
- toLogs(Seq(logLine), appendSentinel)
+ def toLogs(logLine: TypedLogLine, appendSentinel: Boolean):
Queue[TypedLogLine] =
+ toLogs(Queue(logLine), appendSentinel)
- def toLogs(log: Seq[TypedLogLine], appendSentinel: Boolean):
Seq[TypedLogLine] =
+ def toLogs(log: Queue[TypedLogLine], appendSentinel: Boolean):
Queue[TypedLogLine] =
Review comment:
Went with a Queue here as we're mostly appending.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
