KeonHee opened a new pull request #4837: Move the ack implementations to the common package. URL: https://github.com/apache/openwhisk/pull/4837 <!--- Provide a concise summary of your changes in the Title --> ## Description - The ack logic that responds to kafka messages to the controller can be used by other components in the downstream. So move ack logic that is only available in invoker package to common package. - In our downstream, we are creating a new component called [Scheduler](https://cwiki.apache.org/confluence/display/OPENWHISK/Autonomous+Container+Scheduler+v2). The Scheduler performs a kind of queue, where it also responds to queued stale messages to the controller. As such, the ack logic may be used by other components in the downstream, so it seems more appropriate to include it in a common package. And this change has the advantage that the ack logic can be modified more flexibly downstream. - `InvokerReactive` is also new and in use, so I moved `LogsCollector` from `InvokerReactive` to `Invoker` for container log collection. ## My changes affect the following components <!--- Select below all system components are affected by your change. --> <!--- Enter an `x` in all applicable boxes. --> - [ ] API - [ ] Controller - [ ] Message Bus (e.g., Kafka) - [ ] Loadbalancer - [x] Invoker - [ ] Intrinsic actions (e.g., sequences, conductors) - [ ] Data stores (e.g., CouchDB) - [ ] Tests - [ ] Deployment - [ ] CLI - [ ] General tooling - [ ] Documentation ## Types of changes <!--- What types of changes does your code introduce? Use `x` in all the boxes that apply: --> - [ ] Bug fix (generally a non-breaking change which closes an issue). - [x] Enhancement or new feature (adds new functionality). - [ ] Breaking change (a bug fix or enhancement which changes existing behavior). ## Checklist: <!--- Please review the points below which help you make sure you've covered all aspects of the change you're making. --> - [x] I signed an [Apache CLA](https://github.com/apache/openwhisk/blob/master/CONTRIBUTING.md). - [x] I reviewed the [style guides](https://github.com/apache/openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :). - [ ] I added tests to cover my changes. - [ ] My changes require further changes to the documentation. - [ ] I updated the documentation where necessary.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
