codecov-io commented on issue #4837: Move the ack implementations to the common package. URL: https://github.com/apache/openwhisk/pull/4837#issuecomment-591181963 # [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4837?src=pr&el=h1) Report > Merging [#4837](https://codecov.io/gh/apache/openwhisk/pull/4837?src=pr&el=desc) into [master](https://codecov.io/gh/apache/openwhisk/commit/a3d9491faab68196395c8653e08db1422dad57da?src=pr&el=desc) will **increase** coverage by `39.46%`. > The diff coverage is `86.66%`. [](https://codecov.io/gh/apache/openwhisk/pull/4837?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #4837 +/- ## =========================================== + Coverage 36.52% 75.98% +39.46% =========================================== Files 197 198 +1 Lines 9016 9021 +5 Branches 361 353 -8 =========================================== + Hits 3293 6855 +3562 + Misses 5723 2166 -3557 ``` | [Impacted Files](https://codecov.io/gh/apache/openwhisk/pull/4837?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [...che/openwhisk/core/invoker/LogStoreCollector.scala](https://codecov.io/gh/apache/openwhisk/pull/4837/diff?src=pr&el=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvaW52b2tlci9Mb2dTdG9yZUNvbGxlY3Rvci5zY2FsYQ==) | `100% <ø> (ø)` | :arrow_up: | | [.../openwhisk/core/containerpool/ContainerProxy.scala](https://codecov.io/gh/apache/openwhisk/pull/4837/diff?src=pr&el=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXJQcm94eS5zY2FsYQ==) | `93.49% <ø> (+23.84%)` | :arrow_up: | | [...pache/openwhisk/core/invoker/InvokerReactive.scala](https://codecov.io/gh/apache/openwhisk/pull/4837/diff?src=pr&el=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvaW52b2tlci9JbnZva2VyUmVhY3RpdmUuc2NhbGE=) | `80.53% <ø> (+0.7%)` | :arrow_up: | | [...main/scala/org/apache/openwhisk/core/ack/Ack.scala](https://codecov.io/gh/apache/openwhisk/pull/4837/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvYWNrL0Fjay5zY2FsYQ==) | `0% <0%> (ø)` | | | [...apache/openwhisk/core/ack/MessagingActiveAck.scala](https://codecov.io/gh/apache/openwhisk/pull/4837/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvYWNrL01lc3NhZ2luZ0FjdGl2ZUFjay5zY2FsYQ==) | `54.54% <0%> (ø)` | | | [.../org/apache/openwhisk/core/entity/InstanceId.scala](https://codecov.io/gh/apache/openwhisk/pull/4837/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZW50aXR5L0luc3RhbmNlSWQuc2NhbGE=) | `100% <100%> (+11.11%)` | :arrow_up: | | [...la/org/apache/openwhisk/core/invoker/Invoker.scala](https://codecov.io/gh/apache/openwhisk/pull/4837/diff?src=pr&el=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvaW52b2tlci9JbnZva2VyLnNjYWxh) | `72.13% <100%> (+0.46%)` | :arrow_up: | | [...whisk/core/database/cosmosdb/CosmosDBSupport.scala](https://codecov.io/gh/apache/openwhisk/pull/4837/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJTdXBwb3J0LnNjYWxh) | `0% <0%> (ø)` | :arrow_up: | | ... and [126 more](https://codecov.io/gh/apache/openwhisk/pull/4837/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/openwhisk/pull/4837?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4837?src=pr&el=footer). Last update [a3d9491...0430dc0](https://codecov.io/gh/apache/openwhisk/pull/4837?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
