selfxp commented on a change in pull request #4934:
URL: https://github.com/apache/openwhisk/pull/4934#discussion_r457707740
##########
File path:
core/monitoring/user-events/src/main/scala/org/apache/openwhisk/core/monitoring/metrics/PrometheusRecorder.scala
##########
@@ -61,7 +61,9 @@ case class PrometheusRecorder(kamon: PrometheusReporter,
config: MetricConfig)
private val promMetrics = PrometheusMetrics()
override def processActivation(activation: Activation, initiator: String,
metricConfig: MetricConfig): Unit = {
- lookup(activation, initiator).record(activation, initiator, metricConfig)
+ if (!metricConfig.ignoredNamespaces.contains(activation.namespace)) {
Review comment:
I would remove then the `if statement` from inside the [record
method](https://github.com/apache/openwhisk/blob/master/core/monitoring/user-events/src/main/scala/org/apache/openwhisk/core/monitoring/metrics/PrometheusRecorder.scala#L130).
And I would do the same for `KamonRecorder`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
