neerajmangal commented on a change in pull request #4934:
URL: https://github.com/apache/openwhisk/pull/4934#discussion_r457833704
##########
File path:
core/monitoring/user-events/src/main/scala/org/apache/openwhisk/core/monitoring/metrics/PrometheusRecorder.scala
##########
@@ -61,7 +61,9 @@ case class PrometheusRecorder(kamon: PrometheusReporter,
config: MetricConfig)
private val promMetrics = PrometheusMetrics()
override def processActivation(activation: Activation, initiator: String,
metricConfig: MetricConfig): Unit = {
- lookup(activation, initiator).record(activation, initiator, metricConfig)
+ if (!metricConfig.ignoredNamespaces.contains(activation.namespace)) {
Review comment:
Thanks @selfxp. One more thing, I realized with this change
`openwhisk_namespace_activations_total` metric is also not updated. I think
this metric should be updated and not ignored. I will try to extract this
metric to some other place possibly as part of global metrics updates.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
