mhamann opened a new pull request #380: URL: https://github.com/apache/openwhisk-apigateway/pull/380
This is a rather extensive PR. Apologies for that. There were a number of issues discovered upon upgrading from OpenResty 1.13.x to 1.15.x or 1.17.x. The primary problem was that module-level functions weren't declared `local` in previous iterations of apigateway. This didn't seem to matter when we were on OpenResty 1.13.x, although some impact can't be ruled out in high-throughput production environments. OpenResty 1.15 and 1.17 include newer versions of LuaJIT, which seem to be much more sensitive to these types of scope leaks, perhaps due to improved efficiency. Nothing jumped out at me after scanning the commit logs for LuaJIT, but this seems the most likely cause. OpenResty 1.15 also began emitting warnings about global scope `_G` usage, so this PR corrects all of those warnings. Since Lua cares about the order in which things are defined (it's not Javascript, after all), the order of functions across many files has been altered to account for this. Essentially the changes here are: - Upgrade OpenResty to 1.17.x (see #379) - Fix function and variable scoping problems to prevent accidental leakage / overwriting in the global scope (see #378) - Added the `lua-releng` tool to the Travis build in order to prevent scope issues from being introduced in the future - Fixed a few typo bugs that were discovered during the scoping fixes - Prevent tools from being sent to the Docker build ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
