tysonnorris commented on a change in pull request #4935:
URL: https://github.com/apache/openwhisk/pull/4935#discussion_r467294537
##########
File path:
core/controller/src/main/scala/org/apache/openwhisk/core/controller/Actions.scala
##########
@@ -102,6 +104,12 @@ trait WhiskActionsApi extends WhiskCollectionAPI with
PostActionActivation with
/** Database service to get activations. */
protected val activationStore: ActivationStore
+ /** Config flag for Execute Only for Actions in Shared Packages */
+ protected def executeOnly =
+ Try({
+ loadConfigOrThrow[Boolean](ConfigKeys.sharedPackageExecuteOnly)
+ }).getOrElse(false)
Review comment:
Generally the convention so far is to put all defaults into
applicaiton.conf file. So I would a) add a default value (false) for
`whisk.shared-packages-execute-only` into application.conf, and b) remove the
`Try` here since it should always work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
