tysonnorris commented on a change in pull request #4935:
URL: https://github.com/apache/openwhisk/pull/4935#discussion_r467307656
##########
File path:
core/controller/src/main/scala/org/apache/openwhisk/core/controller/Packages.scala
##########
@@ -303,9 +319,20 @@ trait WhiskPackagesApi extends WhiskCollectionAPI with
ReferencedEntities {
logging.error(this, s"unexpected package binding refers to itself:
$docid")
terminate(UnprocessableEntity,
Messages.packageBindingCircularReference(b.fullyQualifiedName.toString))
} else {
- getEntity(WhiskPackage.get(entityStore, docid), Some {
- mergePackageWithBinding(Some { wp }) _
- })
+
+ /** Here's where I check package execute only case with package
binding. */
+ val packagePath = wp.namespace.asString
+ val bindingPath = wp.binding.iterator.next().toString
Review comment:
is `wp.binding.iterator` guaranteed to not be empty?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
