ningyougang commented on pull request #4911:
URL: https://github.com/apache/openwhisk/pull/4911#issuecomment-688568928


   upsteam guy: Tyson replied on dev mail list for this pr as below
   
   ```
   I agree this is a good change, but may require operators to update their 
configured userMemory and/or their prewarm configs
    
   to avoid unexpected problems. It might be good to add some log statements to 
indicate userMemory available AFTER initial 
   
   prewarm config is applied, to give some hints that userMemory seen at 
invoker is now lower than before with the same configs?
   ```
   Regarding ` but may require operators to update their configured userMemory 
and/or their prewarm configs to avoid unexpected problems.`
   Currently, below prs has been implemented with `update their configured 
userMemory and/or their prewarm configs`
   * Adjust user memory via api: https://github.com/apache/openwhisk/pull/4917
   * Add administrative interface to invoker and controller to reconfigure 
prewarm config: https://github.com/apache/openwhisk/pull/4790
   
   Regarding `It might be good to add some log statements to indicate 
userMemory available AFTER initial 
   prewarm config is applied, to give some hints that userMemory seen at 
invoker is now lower than before with the same configs?`
   Agree, i think after above two prs(pull/4917 and pull/4790) merged, i can 
add some logs in this pr after rebased codes.
   
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to