style95 commented on a change in pull request #4911:
URL: https://github.com/apache/openwhisk/pull/4911#discussion_r523422840
##########
File path:
core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/ContainerPool.scala
##########
@@ -131,9 +131,12 @@ class ContainerPool(childFactory: ActorRefFactory =>
ActorRef,
//remove from resent tracking - it may get resent again, or get
processed
resent = None
}
+ val kind = r.action.exec.kind
+ val memory = r.action.limits.memory.megabytes.MB
+
val createdContainer =
// Is there enough space on the invoker for this action to be
executed.
- if (hasPoolSpaceFor(busyPool, r.action.limits.memory.megabytes.MB)) {
+ if (hasPoolSpaceFor(busyPool ++ prewarmedPool, memory)) {
Review comment:
I feel this needs proper documentation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
