bdoyle0182 commented on a change in pull request #4986:
URL: https://github.com/apache/openwhisk/pull/4986#discussion_r496156637



##########
File path: 
common/scala/src/main/scala/org/apache/openwhisk/core/entity/WhiskAction.scala
##########
@@ -548,8 +632,12 @@ object WhiskAction extends DocumentFactory[WhiskAction] 
with WhiskEntityQueries[
       wp flatMap { resolvedPkg =>
         // fully resolved name for the action
         val fqnAction = resolvedPkg.fullyQualifiedName(withVersion = 
false).add(actionName)
+        val action = WhiskActionVersionList.get(fqnAction, 
entityStore).flatMap { result =>

Review comment:
       It might be hard to sort since you'll have to follow semver versus just 
being able to do a lexicographical sort. It should be able to be done though in 
the view definition I think? 
   
   But yea keep in mind:
   [email protected]
   [email protected]
   
   might not get sorted correctly if you don't have semver parsing in your sort




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to