style95 commented on a change in pull request #4986:
URL: https://github.com/apache/openwhisk/pull/4986#discussion_r496312512
##########
File path:
common/scala/src/main/scala/org/apache/openwhisk/core/entity/WhiskAction.scala
##########
@@ -548,8 +632,12 @@ object WhiskAction extends DocumentFactory[WhiskAction]
with WhiskEntityQueries[
wp flatMap { resolvedPkg =>
// fully resolved name for the action
val fqnAction = resolvedPkg.fullyQualifiedName(withVersion =
false).add(actionName)
+ val action = WhiskActionVersionList.get(fqnAction,
entityStore).flatMap { result =>
+ val docId = result.matchedDocId(version).getOrElse(fqnAction.toDocId)
+ WhiskAction.get(entityStore, docId)
Review comment:
@bdoyle0182 That sounds good to me.
Currently, it is too easy to update the action and it is immediately exposed.
In the production system, it is prone to do a mistake even if a proper CI is
settled.
So I imagined having multiple versions with multiple routing just like
blue-green or canary deployment and I believe the feature in this PR would be
the baseline for it.
But at the same time, we can also let users specify and fix a certain
version to be exposed, and make them change the exposed version for the safety.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
