rabbah commented on a change in pull request #349:
URL: https://github.com/apache/openwhisk-release/pull/349#discussion_r500037641
##########
File path: tools/rcverify.sh
##########
@@ -38,6 +38,8 @@ V=${3?"missing version e.g., '3.19.0'"}
# the release candidate, usualy 'rc1'
RC=${4:-rc1}
+REMOVE_DIR=${5:-true}
Review comment:
```suggestion
REMOVE_DIR=${5:-cleanup}
```
##########
File path: tools/rcverify.sh
##########
@@ -212,7 +214,15 @@ packageJsonCheckVersion "$DIR/$BASE/package.json" $V
printf "scanning package-lock.json for version match..."
packageJsonCheckVersion "$DIR/$BASE/package-lock.json" $V
-echo $(tput setaf 6)
-echo run the following command to remove the scratch space:
-echo " rm -rf '$DIR'"
-echo $(tput sgr0)
+if [ "$REMOVE_DIR" = true ]; then
Review comment:
```suggestion
if [ "$REMOVE_DIR" = "cleanup" ]; then
```
only because as a positional argument `true` is ambiguous.
feel free to ignore the suggestion and merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
