style95 commented on a change in pull request #349:
URL: https://github.com/apache/openwhisk-release/pull/349#discussion_r500050275
##########
File path: tools/rcverify.sh
##########
@@ -38,6 +38,8 @@ V=${3?"missing version e.g., '3.19.0'"}
# the release candidate, usualy 'rc1'
RC=${4:-rc1}
+REMOVE_DIR=${5:-true}
Review comment:
Yes. I mentioned it in the PR description as well.
If we need to keep the previous behavior, would be better to change it to
`false`.
But I suppose most people would not need to keep them?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
