ningyougang commented on a change in pull request #5061:
URL: https://github.com/apache/openwhisk/pull/5061#discussion_r570693954
##########
File path:
common/scala/src/main/scala/org/apache/openwhisk/core/entity/InstanceId.scala
##########
@@ -29,11 +29,18 @@ import scala.util.Try
* @param instance a numeric value used for the load balancing and Kafka topic
creation
* @param uniqueName an identifier required for dynamic instance assignment by
Zookeeper
* @param displayedName an identifier that is required for the health protocol
to correlate Kafka topics with invoker container names
+ * @param userMemory invoker user memory
+ * @param busyMemory invoker busy memory
+ * @param tags actions which included specified annotation tags can be run on
this invoker
+ * @param dedicatedNamespaces only dedicatedNamespaces's actions can be run on
this invoker
*/
case class InvokerInstanceId(val instance: Int,
uniqueName: Option[String] = None,
displayedName: Option[String] = None,
- val userMemory: ByteSize)
+ val userMemory: ByteSize,
Review comment:
Good question.
I tested in my local, doesn't affect the message bus. This pr's invoker in
upsteam master's controller's healthy status is `up`.
But your said problem i meet before, in that time, it seems the PingMessage
is changed, so lead to the invoker of new codes in controller of old code's
healthy status is `unhealthy`. if this issue comes. we solved it using another
deployment method, e.g.
* Remove half controller from nginx.
* Disable half invoker
* Deploy half controller/invoker using new codes
* Add the half controller nginx.
* Deploy another half components using above steps
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
