ningyougang commented on a change in pull request #5061:
URL: https://github.com/apache/openwhisk/pull/5061#discussion_r570695768
##########
File path:
common/scala/src/main/scala/org/apache/openwhisk/core/connector/Message.scala
##########
@@ -440,34 +440,6 @@ case class InvokerResourceMessage(status: String,
* Serializes message to string. Must be idempotent.
*/
override def serialize: String =
InvokerResourceMessage.serdes.write(this).compactPrint
-
- def canEqual(a: Any) = a.isInstanceOf[InvokerResourceMessage]
-
- override def equals(that: Any): Boolean =
- that match {
- case that: InvokerResourceMessage => {
- that.canEqual(this) &&
- this.status == that.status &&
- this.freeMemory == that.freeMemory &&
- this.busyMemory == that.busyMemory &&
- this.inProgressMemory == that.inProgressMemory &&
- this.tags.toSet == that.tags.toSet
- this.dedicatedNamespaces.toSet == that.dedicatedNamespaces.toSet
- }
- case _ => false
- }
-
- override def hashCode: Int = {
Review comment:
After removed InvokerResourceMessage's hashCode and equals, i tested
below scenes
for two InvokerResourceMessage object,
* If all field value is same, object1.equals(object) will be `true`,
* if any one filed value is different, object1.equals(object) will be
`false`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
