bdoyle0182 commented on a change in pull request #5098:
URL: https://github.com/apache/openwhisk/pull/5098#discussion_r613634086



##########
File path: 
core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/v2/InvokerHealthManager.scala
##########
@@ -269,6 +270,7 @@ object InvokerHealthManager {
   val healthActionNamePrefix = "invokerHealthTestAction"
   val bufferSize = 10
   val bufferErrorTolerance = 3
+  var useMemory = 0l

Review comment:
       I know that's there only one instance of the invoker health manager per 
instance / jvm, but it still seems risky to be mutating a var in an object like 
this especially when it's the source of truth on whether the invoker is idle or 
not.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to