ningyougang commented on a change in pull request #5098:
URL: https://github.com/apache/openwhisk/pull/5098#discussion_r613717185
##########
File path:
core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/v2/InvokerHealthManager.scala
##########
@@ -269,6 +270,7 @@ object InvokerHealthManager {
val healthActionNamePrefix = "invokerHealthTestAction"
val bufferSize = 10
val bufferErrorTolerance = 3
+ var useMemory = 0l
Review comment:
@style95 @bdoyle0182 , yes, not a good idea of `use mutable variable`
It is better to do like below
```
functionPullingContainerPool.ask(UsedMemory)(Timeout(5.seconds)).mapTo[Int]
```
But functionPullingContainerPool is implementing now, so i removed /memory
api in this pr:
https://github.com/apache/openwhisk/pull/5098/commits/86f55319527b3e757fdefb79212e38f8a51e1135
and i will add /memory api in ` [New Scheduler]
FunctionPullingContainerPool` pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
