rabbah commented on a change in pull request #50:
URL:
https://github.com/apache/openwhisk-runtime-dotnet/pull/50#discussion_r616933874
##########
File path: core/dotnet2.2/QUICKSTART.md
##########
@@ -79,17 +115,27 @@ zip -r -0 helloDotNet.zip *
You need to specify the name of the function handler using `--main` argument.
The value for `main` needs to be in the following format:
-`{Assembly}::{Class Full Name}::{Method}`, e.q.,
-`Apache.OpenWhisk.Example.Dotnet::Apache.OpenWhisk.Example.Dotnet.Hello::Main`
+`{Assembly}::{Class Full Name}::{Method}`, e.q.:
+
++ Synchronous:
`Apache.OpenWhisk.Example.Dotnet::Apache.OpenWhisk.Example.Dotnet.Hello::Main`
++ Asynchronous:
`Apache.OpenWhisk.Example.Dotnet::Apache.OpenWhisk.Example.Dotnet.Hello::MainAsync`
Review comment:
We could simplify the docs - to show the sync case with `Main` first
because i think it's simpler.
Then describe the async case. The function can be called `Main` in both
since the name isn't material.
I think you're right in that as shown it could lead one to think the
name/`Async` suffix is semantically meaningful when it's not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
