mattwelke commented on a change in pull request #50:
URL:
https://github.com/apache/openwhisk-runtime-dotnet/pull/50#discussion_r616995872
##########
File path: core/dotnet2.2/QUICKSTART.md
##########
@@ -79,17 +115,27 @@ zip -r -0 helloDotNet.zip *
You need to specify the name of the function handler using `--main` argument.
The value for `main` needs to be in the following format:
-`{Assembly}::{Class Full Name}::{Method}`, e.q.,
-`Apache.OpenWhisk.Example.Dotnet::Apache.OpenWhisk.Example.Dotnet.Hello::Main`
+`{Assembly}::{Class Full Name}::{Method}`, e.q.:
+
++ Synchronous:
`Apache.OpenWhisk.Example.Dotnet::Apache.OpenWhisk.Example.Dotnet.Hello::Main`
++ Asynchronous:
`Apache.OpenWhisk.Example.Dotnet::Apache.OpenWhisk.Example.Dotnet.Hello::MainAsync`
Review comment:
Glad to hear you agree. After looking again at @shawnallen85 's changs
though, I agree there is one spot it's important to show both. That's at the
very top where it says "that has the exact signature as follows", because in
the async case, the signature is materially different. I think to keep it
simple, everywhere after that first part, it should use just `Main` for the
function name, and show one example regardless of sync/async, because the user
would deploy the sync/async versions (if the main function were named `Main`)
the exact same way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
