bdoyle0182 commented on a change in pull request #5194:
URL: https://github.com/apache/openwhisk/pull/5194#discussion_r790120189
##########
File path: ansible/roles/schedulers/tasks/deploy.yml
##########
@@ -0,0 +1,362 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
contributor
+# license agreements; and to You under the Apache License, Version 2.0.
+---
+# This role will install Scheduler in group 'schedulers' in the environment
+# inventory
+
+- import_tasks: docker_login.yml
+
+- name: get scheduler name and index
+ set_fact:
+ scheduler_name: "{{ name_prefix ~ host_group.index(inventory_hostname) }}"
+ scheduler_index:
+ "{{ (scheduler_index_base|int) + host_group.index(inventory_hostname) }}"
+
+- name: "pull the {{ docker.image.tag }} image of scheduler"
+ shell: "docker pull {{docker_registry}}{{ docker.image.prefix
}}/scheduler:{{docker.image.tag}}"
+ when: docker_registry != ""
+ register: result
+ until: (result.rc == 0)
+ retries: "{{ docker.pull.retries }}"
+ delay: "{{ docker.pull.delay }}"
+
+- name: ensure scheduler log directory is created with permissions
+ file:
+ path: "{{ whisk_logs_dir }}/{{ scheduler_name }}"
+ state: directory
+ mode: 0777
+ become: "{{ logs.dir.become }}"
+
+# We need to create the file with proper permissions because the dir creation
above
+# does not result in a dir with full permissions in docker machine especially
with macos mounts
+- name: ensure scheduler log file is created with permissions
+ file:
+ path: "{{ whisk_logs_dir }}/{{ scheduler_name }}/{{ scheduler_name
}}_logs.log"
+ state: touch
+ mode: 0777
+ when: environment_type is defined and environment_type == "docker-machine"
+
+- name: ensure scheduler config directory is created with permissions
+ file:
+ path: "{{ scheduler.confdir }}/{{ scheduler_name }}"
+ state: directory
+ mode: 0777
+ become: "{{ scheduler.dir.become }}"
+
+- name: check, that required databases exist
+ include_tasks: "{{ openwhisk_home }}/ansible/tasks/db/checkDb.yml"
+ vars:
+ dbName: "{{ item }}"
+ dbUser: "{{ db.credentials.scheduler.user }}"
+ dbPass: "{{ db.credentials.scheduler.pass }}"
+ with_items:
+ - "{{ db.whisk.auth }}"
+
+- name: copy jmxremote password file
+ when: jmx.enabled
+ template:
+ src: "jmxremote.password.j2"
+ dest: "{{ scheduler.confdir }}/{{ scheduler_name }}/jmxremote.password"
+ mode: 0777
+
+- name: copy jmxremote access file
+ when: jmx.enabled
+ template:
+ src: "jmxremote.access.j2"
+ dest: "{{ scheduler.confdir }}/{{ scheduler_name }}/jmxremote.access"
+ mode: 0777
+
+- name: prepare scheduler port
+ set_fact:
+ scheduler_port: "{{ scheduler.basePort + (scheduler_index | int) }}"
+ ports_to_expose:
+ - "{{ scheduler.grpc.basePort + (scheduler_index | int) }}:{{
scheduler.grpc.basePort + (scheduler_index | int) }}"
+ - "{{ scheduler.basePort + (scheduler_index | int) }}:8080"
+
+- name: expose additional ports if jmxremote is enabled
+ when: jmx.enabled
+ vars:
+ jmx_remote_port: "{{ jmx.basePortScheduler + (scheduler_index|int) }}"
+ jmx_remote_rmi_port:
+ "{{ jmx.rmiBasePortScheduler + (scheduler_index|int) }}"
+ set_fact:
+ ports_to_expose: >-
+ {{ ports_to_expose }} +
+ [ '{{ jmx_remote_port }}:{{ jmx_remote_port }}' ] +
+ [ '{{ jmx_remote_rmi_port }}:{{ jmx_remote_rmi_port }}' ]
+ scheduler_args: >-
+ {{ scheduler.arguments }}
+ {{ jmx.jvmCommonArgs }}
+ -Djava.rmi.server.hostname={{ ansible_host }}
+ -Dcom.sun.management.jmxremote.rmi.port={{ jmx_remote_rmi_port }}
+ -Dcom.sun.management.jmxremote.port={{ jmx_remote_port }}
+
+- name: populate environment variables for scheduler
+ set_fact:
+ env:
+ "JAVA_OPTS":
+ -Xmx{{ scheduler.heap }}
+ -XX:+CrashOnOutOfMemoryError
+ -XX:+UseGCOverheadLimit
+ -XX:ErrorFile=/logs/java_error.log
+ -XX:+HeapDumpOnOutOfMemoryError
+ -XX:HeapDumpPath=/logs
+ "SCHEDULER_OPTS": "{{ scheduler_args | default(scheduler.arguments) }}"
+ "SCHEDULER_INSTANCES": "{{ scheduler.instances }}"
+ "JMX_REMOTE": "{{ jmx.enabled }}"
+ "PORT": "8080"
+
+ "WHISK_SCHEDULER_ENDPOINTS_HOST": "{{ ansible_host }}"
+ "WHISK_SCHEDULER_ENDPOINTS_RPCPORT": "{{ scheduler.grpc.basePort +
(scheduler_index | int)}}"
+ "WHISK_SCHEDULER_ENDPOINTS_AKKAPORT": "{{
scheduler.akka.cluster.basePort + (scheduler_index | int) }}"
+ "CONFIG_whisk_scheduler_protocol": "{{ scheduler.protocol }}"
+ "CONFIG_whisk_scheduler_maxPeek": "{{ scheduler.maxPeek }}"
+ "CONFIG_whisk_scheduler_dataManagementService_retryInterval": "{{
scheduler.dataManagementService.retryInterval }}"
+ "CONFIG_whisk_scheduler_inProgressJobRetention": "{{
scheduler.inProgressJobRetentionSecond }}"
+ "CONFIG_whisk_scheduler_queueManager_maxSchedulingTime": "{{
scheduler.queueManager.maxSchedulingTime }}"
+ "CONFIG_whisk_scheduler_queueManager_maxRetriesToGetQueue": "{{
scheduler.queueManager.maxRetriesToGetQueue }}"
+ "CONFIG_whisk_scheduler_queue_idleGrace": "{{ scheduler.queue.idleGrace
}}"
+ "CONFIG_whisk_scheduler_queue_stopGrace": "{{ scheduler.queue.stopGrace
}}"
+ "CONFIG_whisk_scheduler_queue_flushGrace": "{{
scheduler.queue.flushGrace }}"
+ "CONFIG_whisk_scheduler_queue_gracefulShutdownTimeout": "{{
scheduler.queue.gracefulShutdownTimeout }}"
+ "CONFIG_whisk_scheduler_queue_maxRetentionSize": "{{
scheduler.queue.maxRetentionSize }}"
+ "CONFIG_whisk_scheduler_queue_maxRetentionMs": "{{
scheduler.queue.maxRetentionMs }}"
+ "CONFIG_whisk_scheduler_queue_maxBlackboxRetentionMs": "{{
scheduler.queue.maxBlackboxRetentionMs }}"
+ "CONFIG_whisk_scheduler_queue_throttlingFraction": "{{
scheduler.queue.throttlingFraction }}"
+ "CONFIG_whisk_scheduler_queue_durationBufferSize": "{{
scheduler.queue.durationBufferSize }}"
+ "CONFIG_whisk_durationChecker_timeWindow": "{{
durationChecker.timeWindow }}"
+
+ "CONFIG_whisk_watcher_eventNotificationDelayMs": "{{
watcher.eventNotificationDelayMs }}"
+
+ "TZ": "{{ docker.timezone }}"
+
+ "CONFIG_whisk_info_date": "{{ whisk.version.date }}"
+ "CONFIG_whisk_info_buildNo": "{{ docker.image.tag }}"
+
+ "KAFKA_HOSTS": "{{ kafka_connect_string }}"
+ "CONFIG_whisk_kafka_replicationFactor":
+ "{{ kafka.replicationFactor | default() }}"
+ "CONFIG_whisk_kafka_topics_cacheInvalidation_retentionBytes":
+ "{{ kafka_topics_cacheInvalidation_retentionBytes | default() }}"
+ "CONFIG_whisk_kafka_topics_cacheInvalidation_retentionMs":
+ "{{ kafka_topics_cacheInvalidation_retentionMS | default() }}"
+ "CONFIG_whisk_kafka_topics_cacheInvalidation_segmentBytes":
+ "{{ kafka_topics_cacheInvalidation_segmentBytes | default() }}"
+ "CONFIG_whisk_kafka_topics_completed_retentionBytes":
+ "{{ kafka_topics_completed_retentionBytes | default() }}"
+ "CONFIG_whisk_kafka_topics_completed_retentionMs":
+ "{{ kafka_topics_completed_retentionMS | default() }}"
+ "CONFIG_whisk_kafka_topics_completed_segmentBytes":
+ "{{ kafka_topics_completed_segmentBytes | default() }}"
+ "CONFIG_whisk_kafka_topics_health_retentionBytes":
+ "{{ kafka_topics_health_retentionBytes | default() }}"
+ "CONFIG_whisk_kafka_topics_health_retentionMs":
+ "{{ kafka_topics_health_retentionMS | default() }}"
+ "CONFIG_whisk_kafka_topics_health_segmentBytes":
+ "{{ kafka_topics_health_segmentBytes | default() }}"
+ "CONFIG_whisk_kafka_topics_prefix":
+ "{{ kafka.topicsPrefix }}"
+ "CONFIG_whisk_kafka_topics_userEvent_prefix":
+ "{{ kafka.topicsUserEventPrefix }}"
+ "CONFIG_whisk_kafka_common_securityProtocol":
+ "{{ kafka.protocol }}"
+ "CONFIG_whisk_kafka_common_sslTruststoreLocation":
+ "/conf/{{ kafka.ssl.keystore.name }}"
+ "CONFIG_whisk_kafka_common_sslTruststorePassword":
+ "{{ kafka.ssl.keystore.password }}"
+ "CONFIG_whisk_kafka_common_sslKeystoreLocation":
+ "/conf/{{ kafka.ssl.keystore.name }}"
+ "CONFIG_whisk_kafka_common_sslKeystorePassword":
+ "{{ kafka.ssl.keystore.password }}"
+ "ZOOKEEPER_HOSTS": "{{ zookeeper_connect_string }}"
+
+ "LIMITS_ACTIONS_INVOKES_PERMINUTE": "{{ limits.invocationsPerMinute }}"
+ "LIMITS_ACTIONS_INVOKES_CONCURRENT": "{{ limits.concurrentInvocations }}"
+ "LIMITS_TRIGGERS_FIRES_PERMINUTE": "{{ limits.firesPerMinute }}"
+ "LIMITS_ACTIONS_SEQUENCE_MAXLENGTH": "{{ limits.sequenceMaxLength }}"
+
+ "CONFIG_whisk_couchdb_protocol": "{{ db.protocol }}"
+ "CONFIG_whisk_couchdb_host": "{{ db.host }}"
Review comment:
I can't remember what does the scheduler need to communicate with
couchdb for if anything?
##########
File path: ansible/roles/schedulers/tasks/deploy.yml
##########
@@ -0,0 +1,362 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
contributor
+# license agreements; and to You under the Apache License, Version 2.0.
+---
+# This role will install Scheduler in group 'schedulers' in the environment
+# inventory
+
+- import_tasks: docker_login.yml
+
+- name: get scheduler name and index
+ set_fact:
+ scheduler_name: "{{ name_prefix ~ host_group.index(inventory_hostname) }}"
+ scheduler_index:
+ "{{ (scheduler_index_base|int) + host_group.index(inventory_hostname) }}"
+
+- name: "pull the {{ docker.image.tag }} image of scheduler"
+ shell: "docker pull {{docker_registry}}{{ docker.image.prefix
}}/scheduler:{{docker.image.tag}}"
+ when: docker_registry != ""
+ register: result
+ until: (result.rc == 0)
+ retries: "{{ docker.pull.retries }}"
+ delay: "{{ docker.pull.delay }}"
+
+- name: ensure scheduler log directory is created with permissions
+ file:
+ path: "{{ whisk_logs_dir }}/{{ scheduler_name }}"
+ state: directory
+ mode: 0777
+ become: "{{ logs.dir.become }}"
+
+# We need to create the file with proper permissions because the dir creation
above
+# does not result in a dir with full permissions in docker machine especially
with macos mounts
+- name: ensure scheduler log file is created with permissions
+ file:
+ path: "{{ whisk_logs_dir }}/{{ scheduler_name }}/{{ scheduler_name
}}_logs.log"
+ state: touch
+ mode: 0777
+ when: environment_type is defined and environment_type == "docker-machine"
+
+- name: ensure scheduler config directory is created with permissions
+ file:
+ path: "{{ scheduler.confdir }}/{{ scheduler_name }}"
+ state: directory
+ mode: 0777
+ become: "{{ scheduler.dir.become }}"
+
+- name: check, that required databases exist
+ include_tasks: "{{ openwhisk_home }}/ansible/tasks/db/checkDb.yml"
+ vars:
+ dbName: "{{ item }}"
+ dbUser: "{{ db.credentials.scheduler.user }}"
+ dbPass: "{{ db.credentials.scheduler.pass }}"
+ with_items:
+ - "{{ db.whisk.auth }}"
+
+- name: copy jmxremote password file
+ when: jmx.enabled
+ template:
+ src: "jmxremote.password.j2"
+ dest: "{{ scheduler.confdir }}/{{ scheduler_name }}/jmxremote.password"
+ mode: 0777
+
+- name: copy jmxremote access file
+ when: jmx.enabled
+ template:
+ src: "jmxremote.access.j2"
+ dest: "{{ scheduler.confdir }}/{{ scheduler_name }}/jmxremote.access"
+ mode: 0777
+
+- name: prepare scheduler port
+ set_fact:
+ scheduler_port: "{{ scheduler.basePort + (scheduler_index | int) }}"
+ ports_to_expose:
+ - "{{ scheduler.grpc.basePort + (scheduler_index | int) }}:{{
scheduler.grpc.basePort + (scheduler_index | int) }}"
+ - "{{ scheduler.basePort + (scheduler_index | int) }}:8080"
+
+- name: expose additional ports if jmxremote is enabled
+ when: jmx.enabled
+ vars:
+ jmx_remote_port: "{{ jmx.basePortScheduler + (scheduler_index|int) }}"
+ jmx_remote_rmi_port:
+ "{{ jmx.rmiBasePortScheduler + (scheduler_index|int) }}"
+ set_fact:
+ ports_to_expose: >-
+ {{ ports_to_expose }} +
+ [ '{{ jmx_remote_port }}:{{ jmx_remote_port }}' ] +
+ [ '{{ jmx_remote_rmi_port }}:{{ jmx_remote_rmi_port }}' ]
+ scheduler_args: >-
+ {{ scheduler.arguments }}
+ {{ jmx.jvmCommonArgs }}
+ -Djava.rmi.server.hostname={{ ansible_host }}
+ -Dcom.sun.management.jmxremote.rmi.port={{ jmx_remote_rmi_port }}
+ -Dcom.sun.management.jmxremote.port={{ jmx_remote_port }}
+
+- name: populate environment variables for scheduler
+ set_fact:
+ env:
Review comment:
I feel like there's a lot of configs in here not used by the scheduler,
but I could be wrong. Just confusing for what's actually used by the scheduler
and what is just copy paste from other components that doesn't get used
##########
File path:
core/controller/src/main/scala/org/apache/openwhisk/core/loadBalancer/FPCPoolBalancer.scala
##########
@@ -46,7 +46,8 @@ class FPCPoolBalancer(config: WhiskConfig,
extends LoadBalancer {
private implicit val executionContext: ExecutionContext =
actorSystem.dispatcher
- private implicit val requestTimeout: Timeout = Timeout(5.seconds)
+ // This value is given according to the total waiting time at QueueManager
for a new queue to be created.
+ private implicit val requestTimeout: Timeout = Timeout(8.seconds)
Review comment:
was this raised because it took longer than 5 seconds to create for you?
If so should it be raised quite a bit higher?
##########
File path: ansible/roles/schedulers/tasks/deploy.yml
##########
@@ -0,0 +1,362 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
contributor
+# license agreements; and to You under the Apache License, Version 2.0.
+---
+# This role will install Scheduler in group 'schedulers' in the environment
+# inventory
+
+- import_tasks: docker_login.yml
+
+- name: get scheduler name and index
+ set_fact:
+ scheduler_name: "{{ name_prefix ~ host_group.index(inventory_hostname) }}"
+ scheduler_index:
+ "{{ (scheduler_index_base|int) + host_group.index(inventory_hostname) }}"
+
+- name: "pull the {{ docker.image.tag }} image of scheduler"
+ shell: "docker pull {{docker_registry}}{{ docker.image.prefix
}}/scheduler:{{docker.image.tag}}"
+ when: docker_registry != ""
+ register: result
+ until: (result.rc == 0)
+ retries: "{{ docker.pull.retries }}"
+ delay: "{{ docker.pull.delay }}"
+
+- name: ensure scheduler log directory is created with permissions
+ file:
+ path: "{{ whisk_logs_dir }}/{{ scheduler_name }}"
+ state: directory
+ mode: 0777
+ become: "{{ logs.dir.become }}"
+
+# We need to create the file with proper permissions because the dir creation
above
+# does not result in a dir with full permissions in docker machine especially
with macos mounts
+- name: ensure scheduler log file is created with permissions
+ file:
+ path: "{{ whisk_logs_dir }}/{{ scheduler_name }}/{{ scheduler_name
}}_logs.log"
+ state: touch
+ mode: 0777
+ when: environment_type is defined and environment_type == "docker-machine"
+
+- name: ensure scheduler config directory is created with permissions
+ file:
+ path: "{{ scheduler.confdir }}/{{ scheduler_name }}"
+ state: directory
+ mode: 0777
+ become: "{{ scheduler.dir.become }}"
+
+- name: check, that required databases exist
+ include_tasks: "{{ openwhisk_home }}/ansible/tasks/db/checkDb.yml"
+ vars:
+ dbName: "{{ item }}"
+ dbUser: "{{ db.credentials.scheduler.user }}"
+ dbPass: "{{ db.credentials.scheduler.pass }}"
+ with_items:
+ - "{{ db.whisk.auth }}"
+
+- name: copy jmxremote password file
+ when: jmx.enabled
+ template:
+ src: "jmxremote.password.j2"
+ dest: "{{ scheduler.confdir }}/{{ scheduler_name }}/jmxremote.password"
+ mode: 0777
+
+- name: copy jmxremote access file
+ when: jmx.enabled
+ template:
+ src: "jmxremote.access.j2"
+ dest: "{{ scheduler.confdir }}/{{ scheduler_name }}/jmxremote.access"
+ mode: 0777
+
+- name: prepare scheduler port
+ set_fact:
+ scheduler_port: "{{ scheduler.basePort + (scheduler_index | int) }}"
+ ports_to_expose:
+ - "{{ scheduler.grpc.basePort + (scheduler_index | int) }}:{{
scheduler.grpc.basePort + (scheduler_index | int) }}"
+ - "{{ scheduler.basePort + (scheduler_index | int) }}:8080"
+
+- name: expose additional ports if jmxremote is enabled
+ when: jmx.enabled
+ vars:
+ jmx_remote_port: "{{ jmx.basePortScheduler + (scheduler_index|int) }}"
+ jmx_remote_rmi_port:
+ "{{ jmx.rmiBasePortScheduler + (scheduler_index|int) }}"
+ set_fact:
+ ports_to_expose: >-
+ {{ ports_to_expose }} +
+ [ '{{ jmx_remote_port }}:{{ jmx_remote_port }}' ] +
+ [ '{{ jmx_remote_rmi_port }}:{{ jmx_remote_rmi_port }}' ]
+ scheduler_args: >-
+ {{ scheduler.arguments }}
+ {{ jmx.jvmCommonArgs }}
+ -Djava.rmi.server.hostname={{ ansible_host }}
+ -Dcom.sun.management.jmxremote.rmi.port={{ jmx_remote_rmi_port }}
+ -Dcom.sun.management.jmxremote.port={{ jmx_remote_port }}
+
+- name: populate environment variables for scheduler
+ set_fact:
+ env:
+ "JAVA_OPTS":
+ -Xmx{{ scheduler.heap }}
+ -XX:+CrashOnOutOfMemoryError
+ -XX:+UseGCOverheadLimit
+ -XX:ErrorFile=/logs/java_error.log
+ -XX:+HeapDumpOnOutOfMemoryError
+ -XX:HeapDumpPath=/logs
+ "SCHEDULER_OPTS": "{{ scheduler_args | default(scheduler.arguments) }}"
+ "SCHEDULER_INSTANCES": "{{ scheduler.instances }}"
+ "JMX_REMOTE": "{{ jmx.enabled }}"
+ "PORT": "8080"
+
+ "WHISK_SCHEDULER_ENDPOINTS_HOST": "{{ ansible_host }}"
+ "WHISK_SCHEDULER_ENDPOINTS_RPCPORT": "{{ scheduler.grpc.basePort +
(scheduler_index | int)}}"
+ "WHISK_SCHEDULER_ENDPOINTS_AKKAPORT": "{{
scheduler.akka.cluster.basePort + (scheduler_index | int) }}"
+ "CONFIG_whisk_scheduler_protocol": "{{ scheduler.protocol }}"
+ "CONFIG_whisk_scheduler_maxPeek": "{{ scheduler.maxPeek }}"
+ "CONFIG_whisk_scheduler_dataManagementService_retryInterval": "{{
scheduler.dataManagementService.retryInterval }}"
+ "CONFIG_whisk_scheduler_inProgressJobRetention": "{{
scheduler.inProgressJobRetentionSecond }}"
+ "CONFIG_whisk_scheduler_queueManager_maxSchedulingTime": "{{
scheduler.queueManager.maxSchedulingTime }}"
+ "CONFIG_whisk_scheduler_queueManager_maxRetriesToGetQueue": "{{
scheduler.queueManager.maxRetriesToGetQueue }}"
+ "CONFIG_whisk_scheduler_queue_idleGrace": "{{ scheduler.queue.idleGrace
}}"
+ "CONFIG_whisk_scheduler_queue_stopGrace": "{{ scheduler.queue.stopGrace
}}"
+ "CONFIG_whisk_scheduler_queue_flushGrace": "{{
scheduler.queue.flushGrace }}"
+ "CONFIG_whisk_scheduler_queue_gracefulShutdownTimeout": "{{
scheduler.queue.gracefulShutdownTimeout }}"
+ "CONFIG_whisk_scheduler_queue_maxRetentionSize": "{{
scheduler.queue.maxRetentionSize }}"
+ "CONFIG_whisk_scheduler_queue_maxRetentionMs": "{{
scheduler.queue.maxRetentionMs }}"
+ "CONFIG_whisk_scheduler_queue_maxBlackboxRetentionMs": "{{
scheduler.queue.maxBlackboxRetentionMs }}"
+ "CONFIG_whisk_scheduler_queue_throttlingFraction": "{{
scheduler.queue.throttlingFraction }}"
+ "CONFIG_whisk_scheduler_queue_durationBufferSize": "{{
scheduler.queue.durationBufferSize }}"
+ "CONFIG_whisk_durationChecker_timeWindow": "{{
durationChecker.timeWindow }}"
+
+ "CONFIG_whisk_watcher_eventNotificationDelayMs": "{{
watcher.eventNotificationDelayMs }}"
+
+ "TZ": "{{ docker.timezone }}"
+
+ "CONFIG_whisk_info_date": "{{ whisk.version.date }}"
+ "CONFIG_whisk_info_buildNo": "{{ docker.image.tag }}"
+
+ "KAFKA_HOSTS": "{{ kafka_connect_string }}"
+ "CONFIG_whisk_kafka_replicationFactor":
+ "{{ kafka.replicationFactor | default() }}"
+ "CONFIG_whisk_kafka_topics_cacheInvalidation_retentionBytes":
+ "{{ kafka_topics_cacheInvalidation_retentionBytes | default() }}"
+ "CONFIG_whisk_kafka_topics_cacheInvalidation_retentionMs":
+ "{{ kafka_topics_cacheInvalidation_retentionMS | default() }}"
+ "CONFIG_whisk_kafka_topics_cacheInvalidation_segmentBytes":
+ "{{ kafka_topics_cacheInvalidation_segmentBytes | default() }}"
+ "CONFIG_whisk_kafka_topics_completed_retentionBytes":
+ "{{ kafka_topics_completed_retentionBytes | default() }}"
+ "CONFIG_whisk_kafka_topics_completed_retentionMs":
+ "{{ kafka_topics_completed_retentionMS | default() }}"
+ "CONFIG_whisk_kafka_topics_completed_segmentBytes":
+ "{{ kafka_topics_completed_segmentBytes | default() }}"
+ "CONFIG_whisk_kafka_topics_health_retentionBytes":
+ "{{ kafka_topics_health_retentionBytes | default() }}"
+ "CONFIG_whisk_kafka_topics_health_retentionMs":
+ "{{ kafka_topics_health_retentionMS | default() }}"
+ "CONFIG_whisk_kafka_topics_health_segmentBytes":
+ "{{ kafka_topics_health_segmentBytes | default() }}"
+ "CONFIG_whisk_kafka_topics_prefix":
+ "{{ kafka.topicsPrefix }}"
+ "CONFIG_whisk_kafka_topics_userEvent_prefix":
+ "{{ kafka.topicsUserEventPrefix }}"
+ "CONFIG_whisk_kafka_common_securityProtocol":
+ "{{ kafka.protocol }}"
+ "CONFIG_whisk_kafka_common_sslTruststoreLocation":
+ "/conf/{{ kafka.ssl.keystore.name }}"
+ "CONFIG_whisk_kafka_common_sslTruststorePassword":
+ "{{ kafka.ssl.keystore.password }}"
+ "CONFIG_whisk_kafka_common_sslKeystoreLocation":
+ "/conf/{{ kafka.ssl.keystore.name }}"
+ "CONFIG_whisk_kafka_common_sslKeystorePassword":
+ "{{ kafka.ssl.keystore.password }}"
+ "ZOOKEEPER_HOSTS": "{{ zookeeper_connect_string }}"
+
+ "LIMITS_ACTIONS_INVOKES_PERMINUTE": "{{ limits.invocationsPerMinute }}"
Review comment:
Are these throttling limits needed to be configured for the scheduler
component?
##########
File path: common/scala/src/main/resources/application.conf
##########
@@ -197,6 +209,11 @@ whisk {
retention-bytes = 1073741824
retention-ms = 3600000
}
+ actions {
Review comment:
what produces to and consumes from this topic? And what is produced?
edit: Looking at the `Scheduler.scala` file on line 332 it seems like this
config is just used as the configuration for the `scheduler[idx]` topics, not
actually topics created called actions? With that said should this config be
renamed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
