ningyougang commented on code in PR #5222:
URL: https://github.com/apache/openwhisk/pull/5222#discussion_r857084024
##########
core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/docker/DockerClient.scala:
##########
@@ -203,8 +203,15 @@ class DockerClient(dockerHost: Option[String] = None,
LoggingMarkers.INVOKER_DOCKER_CMD(args.head),
s"running ${cmd.mkString(" ")} (timeout: $timeout)",
logLevel = InfoLevel)
+ val t0 = System.currentTimeMillis()
executeProcess(cmd, timeout).andThen {
- case Success(_) => transid.finished(this, start)
+ case Success(_) =>
+ val t1 = System.currentTimeMillis()
+ MetricEmitter.emitHistogramMetric(
+ LogMarkerToken("docker", "runCmd", "duration", Some(args.head),
Map("cmd" -> args.head))(
+ MeasurementUnit.time.milliseconds),
Review Comment:
In this pr, since `kubeapi for create pod consume time metric` is added, it
is better to add `docker for create common container consume time metric`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
