bdoyle0182 commented on code in PR #5222:
URL: https://github.com/apache/openwhisk/pull/5222#discussion_r868854600
##########
core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/v2/FunctionPullingContainerPool.scala:
##########
@@ -111,6 +111,14 @@ class FunctionPullingContainerPool(
MetricEmitter
.emitHistogramMetric(LoggingMarkers.INVOKER_CONTAINERPOOL_MEMORY("prewarmed"),
memoryConsumptionOf(prewarmedPool))
MetricEmitter.emitHistogramMetric(LoggingMarkers.INVOKER_CONTAINERPOOL_MEMORY("max"),
poolConfig.userMemory.toMB)
+ val prewarmedSize = prewarmedPool.size
+ val busySize = busyPool.size
+ val warmedSize = warmedPool.size
+ val allSize = prewarmedSize + busySize + warmedSize
+
MetricEmitter.emitHistogramMetric(LoggingMarkers.INVOKER_CONTAINERPOOL_CONTAINER("prewarmed"),
prewarmedSize)
+
MetricEmitter.emitHistogramMetric(LoggingMarkers.INVOKER_CONTAINERPOOL_CONTAINER("busy"),
busySize)
+
MetricEmitter.emitHistogramMetric(LoggingMarkers.INVOKER_CONTAINERPOOL_CONTAINER("warmed"),
warmedSize)
+
MetricEmitter.emitHistogramMetric(LoggingMarkers.INVOKER_CONTAINERPOOL_CONTAINER("all"),
allSize)
Review Comment:
Yep this a great metric addition and needed. Should we include namespace and
action as tags here as well for the warmed containers? If needed in a separate
metric. I think it's useful as well to know what invokers a namespace and
actions are running on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
