style95 commented on code in PR #5228:
URL: https://github.com/apache/openwhisk/pull/5228#discussion_r861641849
##########
core/scheduler/src/main/scala/org/apache/openwhisk/core/scheduler/queue/MemoryQueue.scala:
##########
@@ -561,6 +561,20 @@ class MemoryQueue(private val etcdClient: EtcdClient,
// let QueueManager know this queue is no longer in charge.
context.parent ! staleQueueRemovedMsg
+ if (queue.size > 0) {
+ // if doesn't exist old container to pull old memoryQueue's
activation, complete the activation directly
+ if (containers.size == 0) {
Review Comment:
I think we need to consider containers being created(in-progress containers).
And it's worth discussing but IIRC, in our downstream, we decided to promote
the old version of activations to the latest one rather than just completing
them with errors.
If we do this, I think QueueManager should act in the same way for stale
activations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
