jiangpengcheng commented on code in PR #5228:
URL: https://github.com/apache/openwhisk/pull/5228#discussion_r867312939
##########
tests/src/test/scala/org/apache/openwhisk/core/scheduler/queue/test/MemoryQueueFlowTests.scala:
##########
@@ -1534,20 +1536,14 @@ class MemoryQueueFlowTests
probe.expectTerminated(fsm, 10.seconds)
case _ =>
- // queue is stale and will be removed
+ fsm.underlyingActor.containers = Set(testContainerId)
parent.expectMsg(staleQueueRemovedMsg)
+ parent.expectMsg(message)
+ // queue is stale and will be removed
probe.expectMsg(Transition(fsm, state, Removing))
fsm ! QueueRemovedCompleted
- // queue should not be terminated as there is an activation
Review Comment:
why these lines are removed? since there is a container in
https://github.com/apache/openwhisk/pull/5228/files#diff-4b5788222d7949baf4e09b570e4fa49d3fa79e5432ff50c798b04353758c8d4aR1539,
I think message should not be sent to `QueueManager`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
