[GitHub] [openwhisk] upgle opened a new pull request, #5229: [Proposal] Provide different action limits for different namespaces

[GitBox]

upgle opened a new pull request, #5229:
URL: https://github.com/apache/openwhisk/pull/5229

   <!--- Provide a concise summary of your changes in the Title -->
   
   ## Description
   <!--- Provide a detailed description of your changes. -->
   <!--- Include details of what problem you are solving and how your changes 
are tested. -->
   
   Currently, openwhisk has only the system limit shared by all namespaces. I 
have received requirements to set different limits for each namespace/user. So 
I propose a new feature for namespace limit.
   
   - There are **(1) system limits**, **(2) namespace default limits**, **(3) 
namespace limits**.
     - (1) system limits: under no circumstances may this limit be exceeded.
     - (2) namespace default limits: use this limit value unless a limit has 
been set in the namespace.
     - (3) namespace limit: It can be set by the system administrator. This 
value cannot exceed the range of the system limit.
   
   _case1) Using default namespace limit_
   <img 
src="https://user-images.githubusercontent.com/5635513/166409786-bb6759f8-e860-4f1e-8524-a91cc8ddd2f9.png";
 width="600">
   
   _case1) Using namespace limit (for `foo` namespace)_
   <img 
src="https://user-images.githubusercontent.com/5635513/166409938-66a257e5-e9a5-4031-9f3a-a0001a9c5c93.png";
 width="600">
   
   ### Limit doc
   You can set namespace limits with `{namespace}/limits` document just like 
any other existing setting.
   
   ```json
   {
     "concurrentInvocations": 100,
     "invocationsPerMinute": 100,
     "firesPerMinute": 100,
     "memoryMax": 128,
     "concurrencyMax": 400
     "logMax": 128
   }
   ```
   
   ### New namespace limit config
   config key | description
   -- | --
   memoryMin | minimum action memory size for namespace
   memoryMax | maximum action memory size for namespace
   logMin | minimum activation log size for namespace
   logMax | maximum activation log size for namespace
   durationMin | minimum action time limit for namespace
   durationMax | maximum action time limit for namespace
   concurrencyMin | minimum action concurrency limit for namespace
   concurrencyMax | maximum action concurrency limit for namespace
   
   
   ## Related issue and scope
   <!--- Please include a link to a related issue if there is one. -->
   I didn't open new issue, but described the changes here.
   
   ## My changes affect the following components
   <!--- Select below all system components are affected by your change. -->
   <!--- Enter an `x` in all applicable boxes. -->
   - [x] API
   - [x] Controller
   - [x] Tests
   - [ ] Documentation
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Use `x` in all the 
boxes that apply: -->
   - [ ] Bug fix (generally a non-breaking change which closes an issue).
   - [x] Enhancement or new feature (adds new functionality).
   - [ ] Breaking change (a bug fix or enhancement which changes existing 
behavior).
   
   ## Checklist:
   <!--- Please review the points below which help you make sure you've covered 
all aspects of the change you're making. -->
   
   - [x] I signed an [Apache 
CLA](https://github.com/apache/openwhisk/blob/master/CONTRIBUTING.md).
   - [x] I reviewed the [style 
guides](https://github.com/apache/openwhisk/blob/master/CONTRIBUTING.md#coding-standards)
 and followed the recommendations (Travis CI will check :).
   - [x] I added tests to cover my changes.
   - [ ] My changes require further changes to the documentation.
   - [ ] I updated the documentation where necessary.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org