upgle commented on code in PR #5229:
URL: https://github.com/apache/openwhisk/pull/5229#discussion_r867615556
##########
core/controller/src/main/scala/org/apache/openwhisk/core/controller/Actions.scala:
##########
@@ -212,11 +212,13 @@ trait WhiskActionsApi extends WhiskCollectionAPI with
PostActionActivation with
parameter('overwrite ? false) { overwrite =>
entity(as[WhiskActionPut]) { content =>
val request = content.resolve(user.namespace)
- val checkAdditionalPrivileges = entitleReferencedEntities(user,
Privilege.READ, request.exec).flatMap {
- case _ => entitlementProvider.check(user, content.exec)
- }
+ val check = for {
+ checkLimits <- checkNamespaceAndSystemLimits(user, content)
Review Comment:
@ningyougang
It is an existing spec to check the limit when creating an action.
You still can't create an action that exceeds the system limit.
And this method is to check the limit of the namespace along with the system
limit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
