[GitHub] [openwhisk] ningyougang commented on a diff in pull request #5278: Prepare to integrate new scheduler into apache/openwhisk-deploy-kube

Wed, 20 Jul 2022 20:32:28 -0700 


ningyougang commented on code in PR #5278:
URL: https://github.com/apache/openwhisk/pull/5278#discussion_r926221471


##########
core/controller/src/main/scala/org/apache/openwhisk/core/controller/Controller.scala:
##########
@@ -230,6 +233,10 @@ object Controller {
   def main(args: Array[String]): Unit = {
     implicit val actorSystem = ActorSystem("controller-actor-system")
     implicit val logger = new 
AkkaLogging(akka.event.Logging.getLogger(actorSystem, this))
+    if (useClusterBootstrap) {
+      AkkaManagement(actorSystem).start()
+      ClusterBootstrap(actorSystem).start()
+    }

Review Comment:
   As far as i know, ShardingContainerPoolBalancer already has relative logic.
   
![image](https://user-images.githubusercontent.com/11749867/180123883-40e882ea-9c7f-4d1f-aa05-82c35ff52217.png)
   Since ShardingContainerPoolBalancer's codes and these codes locates in same 
place, does it repeat?
   
   Currently, we have ShardingContainerBalancer and FPCPoolBalancer, seems can 
delete the Sharding one, just keep here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to